Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken build #3883

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Fix broken build #3883

merged 2 commits into from
Feb 28, 2020

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Feb 27, 2020 •
edited
Loading

Fixes #3882

@greg0ire
Copy link
Member Author

🤔 no package on hold before we run ACCEPT_EULA=Y sudo apt-get install -qy msodbcsql17 unixodbc unixodbc-dev libssl1.0.0

@greg0ire greg0ire force-pushed the troubleshoot-apt-issue branch from f240e02 to 8b9b37d Compare February 27, 2020 19:41
@greg0ire
Copy link
Member Author

greg0ire commented Feb 27, 2020 •
edited
Loading

Switching to bionic fixed the issue, but new issues arise with other jobs. I'm going to try cherry-picking stuff from master.

@greg0ire
Copy link
Member Author

I'm targeting 2.11.x, because that's where the bug was observed, but I'm unsure where this should go, because the branch metadata seems to be outdated:

dbal/.doctrine-project.json

Lines 8 to 23 in 5fec6ea

{
"name": "3.0",
"branchName": "master",
"slug": "latest",
"upcoming": true
},
{
"name": "2.10",
"branchName": "2.10",
"slug": "2.10",
"current": true,
"aliases": [
"current",
"stable"
]
},

@greg0ire greg0ire force-pushed the troubleshoot-apt-issue branch from a790933 to 699cb47 Compare February 27, 2020 20:11
@SenseException
Copy link
Member

AFAIK 2.10.x is still supported.

@greg0ire
Copy link
Member Author

The build is almost green, but I'm going to have to drop MariaDB 10.0:

  • cannot be installed
  • no longer supported anyway

@greg0ire
Copy link
Member Author

Same goes for Postgresql 9.2 and 9.3.

@greg0ire greg0ire changed the base branch from 2.11.x to 2.10.x February 27, 2020 20:25
@greg0ire greg0ire force-pushed the troubleshoot-apt-issue branch from 699cb47 to 5c858c4 Compare February 27, 2020 20:25
@greg0ire greg0ire changed the title Troubleshoot APT issue don't mind me Fix broken build Feb 27, 2020
@greg0ire greg0ire requested a review from a team February 27, 2020 20:48
@SenseException
Copy link
Member

The build is almost green, but I'm going to have to drop MariaDB 10.0:

Same goes for Postgresql 9.2 and 9.3.

Maybe that shouldn't be much of a problem for these unsupported versions. A drop already happened in develop with #3477.

@greg0ire
Copy link
Member Author

🤔 shouldn't that PR have targeted the stable branch?

@SenseException
Copy link
Member

Dropping support would be a BC break. Develop was the next major version.

SenseException
SenseException approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question though: Can mariadb.mysqli.travis.xml be dropped in favor of using mariadb.mysqli.docker.travis.xml?

@greg0ire
Copy link
Member Author

Not sure what you mean… that would mean changing the user and port for some builds, right?

@SenseException
Copy link
Member

@greg0ire Yes, it would use Docker for the other MariaDB too.

@greg0ire
Copy link
Member Author

greg0ire commented Feb 28, 2020 •
edited
Loading

I'm going to just merge since this is critical (the build is broken). I'm marking this as unread to try and do what you suggest.

@greg0ire greg0ire merged commit 96d10bd into doctrine:2.10.x Feb 28, 2020
@greg0ire greg0ire deleted the troubleshoot-apt-issue branch February 28, 2020 13:21
@greg0ire greg0ire mentioned this pull request Feb 28, 2020
Merged
@morozov morozov added this to the 2.10.2 milestone Mar 30, 2020
@doctrinebot doctrinebot mentioned this pull request Apr 20, 2020
Merged
rgrellmann added a commit to Rossmann-IT/dbal that referenced this pull request Apr 22, 2020
@rgrellmann
Merge tag '2.10.2' into oracle122
1a8890a 
Release [2.10.2](https://github.com/doctrine/dbal/milestone/75)

2.10.2
======

- Total issues resolved: **4**
- Total pull requests resolved: **19**
- Total contributors: **10**

Improvement,Static Analysis
---------------------------

 - [3964: Mark every exception as immutable](doctrine#3964) thanks to @greg0ire

CI,Improvement,Static Analysis
------------------------------

 - [3961: Stop relying on the master version of Psalm](doctrine#3961) thanks to @greg0ire
 - [3951: Setup static analysis with Psalm](doctrine#3951) thanks to @greg0ire
 - [3799: Upgrade to PHPStan v0.12](doctrine#3799) thanks to @lcobucci

Improvement,Logging,Test Suite
------------------------------

 - [3957: Reworked LoggingTest to be able to test Statement::executeUpdate()](doctrine#3957) thanks to @morozov

CI,Code Style,Improvement,Strict Typing
---------------------------------------

 - [3955: Remove baseline](doctrine#3955) thanks to @greg0ire

Bug,SQLite,Schema Introspection,Schema Managers
-----------------------------------------------

 - [3937: Column comment incorrectly introspected on SQLite](doctrine#3937) thanks to @morozov

Bug,Documentation,Prepared Statements,Query
-------------------------------------------

 - [3896: Updated documentation for QueryBuilder::execute() return value type](doctrine#3896) thanks to @morozov

Bug,Prepared Statements
-----------------------

 - [3894: Make sure that the $types array has the same keys $params](doctrine#3894) thanks to @morozov
 - [3893: Ensure the constructor arguments are passed to custom classes](doctrine#3893) thanks to @duncan3dc
 - [3843: Fix unquoted stmt fragments backslash escaping](doctrine#3843) thanks to @morozov

Documentation,Improvement
-------------------------

 - [3886: Update readme](doctrine#3886) thanks to @greg0ire
 - [3834: Fix docblock typos in DriverManager docs](doctrine#3834) thanks to @CHItA

CI,Improvement,MariaDB,MySQL
----------------------------

 - [3884: Use Docker consistently](doctrine#3884) thanks to @greg0ire
 - [3478: Improve readiness probe stability for containerized databases on CI](doctrine#3478) thanks to @morozov

 - [3883: Fix broken build](doctrine#3883) thanks to @greg0ire

Bug,Documentation,Query,Query Limit/Offset Modification
-------------------------------------------------------

 - [3842: Fixed the QueryBuilder::setMaxResults() signature to accept NULL](doctrine#3842) thanks to @morozov

Bug,Query
---------

 - [3832: Fix JOIN with no condition bug](doctrine#3832) thanks to @BenMorel

Bug,PostgreSQL,Schema Introspection
-----------------------------------

 - [3821: &doctrine#91;pg&doctrine#93; fix getting table information if search&doctrine#95;path contains escaped schema name](doctrine#3821) thanks to @linniksa

Documentation,Improvement,Logging
---------------------------------

 - [3812: Fix DebugStack#queries docblock type](doctrine#3812) thanks to @ostrolucky

Bug,Regression,Schema
---------------------

 - [3790: fixed unqualified table name of fk constraints when using schemas](doctrine#3790) thanks to @stlrnz and @Alarich

# gpg: Signature made Mon Apr 20 19:59:36 2020
# gpg:                using DSA key 2C3A645671828132
# gpg: Can't check signature: public key not found

# Conflicts:
#	README.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

@SenseException SenseException SenseException approved these changes

Assignees

@greg0ire greg0ire

Labels
None yet
Projects
None yet
Milestone
2.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @SenseException @morozov